grafana/k6

Better metrics about sleep and group

Open

#921 opened on Feb 8, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (1,537 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (30,564 stars)
PR merge metrics
 (Avg merge 11d 15h) (47 merged PRs in 30d)

Description

Currently if a group includes a 10 second sleep we are going to say that the group took 10 seconds, which while correct might not be what the enduser is interested in. I propose that we:

  1. implement #880
  2. Have the group know that there was n seconds of sleep in it's current execution - probably through some new methods on lib.Group
  3. Add new metric group_sleep?
  4. Choose whether to remove the sleep time from the group_duration or add another metric that is the group_duration without the group_sleep or the reverse - have the group_duration be without the group_sleep but have another full_group_duration that includes the group_sleep

Contributor guide

Research direction
Study the existing metrics system, particularly lib.Group, and understand how sleep is handled. Propose how to track sleep time within group execution, then implement new metrics or modify group duration.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gok6 basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50