grafana/k6

Move Sobek option parsing to the mapping layer

Open

#5305 opened on Oct 14, 2025

View on GitHub
 (22 comments) (0 reactions) (1 assignee)Go (30,564 stars) (1,537 forks)batch import
area: browsergood first issuerefactor

Description

What

  • Move Sobek option parsing to the mapping layer.

Why

  • Separation of concerns.
  • Option parsing is only required by the mapping layer.
  • To simplify and make the code and tests easy to reason about.

Current options to move

  • Frame options
  • Locator options
  • ElementHandleBaseOptions
  • #5687
  • PageReloadOptions
  • PageScreenshotOptions
  • Size.Parse
  • #5302
  • #5560

Example

  • In this code, the parsing happens in the mapping layer.

Related

  • This issue is a continuation of the epic issue #4219.

Contributor guide

Tech stack
go
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingk6 codebase structureSobek API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the existing mapping layer in files like locator mapping.go and browser mapping.go to understand the current pattern. Review the list of options to be moved, noting that some are already completed (e.g., #5687, #5302, #5560). Discuss with the assignee to coordinate work. Ensure each option is moved following the separation of concerns principle, with updated tests.