grafana/k6

Update protobuf library

Open

#4,585 opened on Nov 8, 2022

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Go (30,564 stars) (1,537 forks)batch import
area: prometheusrwenhancementevaluation neededgood first issuetriage

Description

grafana/xk6-output-prometheus-remote#49 is going to replace the current golang/protobuf with gogo/protobuf so it aligns with the library currently used by Prometheus. gogo has a good reputation for performance efficiency, but unfortunately, it has been deprecated so it would be better to switch to a more reliable library. planetscale/vtprotobuf could be a good alternative.

Benchmarks and tests should be added for a good comparison.

Contributor guide

Tech stack
go
Domain
backendperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingProtobuf basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current usage of golang/protobuf in the k6 codebase, likely in the output package for prometheus remote write. Review the linked PR grafana/xk6 output prometheus remote#49 to understand the replacement with gogo/protobuf. Then, explore planetscale/vtprotobuf as an alternative, and design benchmarks to compare performance. The implementation would involve modifying Go source files, likely in the output/prometheus directory.