grafana/k6

Support for `Ed(X)25519`

Open

#4,263 opened on Oct 30, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Go (30,564 stars) (1,537 forks)batch import
area: webcryptoenhancementgood first issuehelp wanted

Description

What?

Even though original WebCrypto API doesn't include support of the Curve25519, but many of webcrypto implementation does https://github.com/w3c/webcrypto/pull/362

Even WebPlatfrom test suit tests this support, which led us to patch https://github.com/grafana/k6/blob/master/internal/js/modules/k6/webcrypto/tests/wpt-patches/WebCryptoAPI__generateKey__failures.js.patch

Draft can be found https://wicg.github.io/webcrypto-secure-curves/

From the Golang's perspective, support also looks good since we have packages:

Why?

Seems like support of this Curve25519 is demanded, so having it in k6 makes k6's implementation more attractive and useful for customers.

Contributor guide

Tech stack
javascriptgo
Domain
securityapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingcryptography basicsWebCrypto API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Implement Ed25519 and X25519 support in k6's webcrypto module. Refer to the existing WPT patch at internal/js/modules/k6/webcrypto/tests/wpt patches/WebCryptoAPI generateKey failures.js.patch. Use Go's crypto/ed25519 and golang.org/x/crypto/curve25519 packages. Follow the WICG draft at https://wicg.github.io/webcrypto secure curves/. Ensure compatibility with WebCrypto API tests.