grafana/k6

Look into protobuf edition support

Open

#3,816 opened on Jun 26, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (30,564 stars) (1,537 forks)batch import
area: grpcevaluation neededhelp wanted

Description

After #3815 is merged a few dependencies seem to have support for it.

The https://github.com/jhump/protoreflect/releases/tag/v1.16.0 says protoparse doesn't yet - which seems to be the one we care about.

I am opening this issues so that we can appropriately test and do changes once this is implemented. Or even look into it earlier.

Contributor guide

Tech stack
go
Domain
backendtesting
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Go programmingProtocol Buffersk6 codebase basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the status of protobuf edition support in the jhump/protoreflect library, specifically in the protoparse package. Check for updates on the linked issue or PR in that repository. Once support is added, test integration in the k6 codebase, particularly in any protobuf related modules. Ensure compatibility with existing Go protobuf code and update dependencies accordingly.
Look into protobuf edition support · grafana/k6#3816 | Good First Issue