grafana/k6

Run tests in separate process so that we actually test loading proto definitions at runtime

Open

#3552 opened on Jul 5, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (30,564 stars) (1,537 forks)batch import
area: grpccihelp wantedtests

Description

Originally raised in this comment by @thiagodpf.

What?

The current unit tests run the server and clients in the same process.

gRPC seems to have a global registry for types, so once the server loads them, the client doesn't need to.

This means that all tests that test that clients actually manage to load types correctly only with .proto files are not actually testing that :(

Solutions:

Preferably go test ./... should run the unit tests with the server and client as separate process - preferably even separate from the main go test one :thinking:

This sounds involved.

A quicker solution will be to have another CI step that runs a server + k6 run script.js exercising the most common cases.

Both will be best.

Contributor guide

Tech stack
gojavascript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingtesting experiencegRPC basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current test structure in the k6 repository, particularly around gRPC tests. The issue references a comment in issue #3160. Consider implementing a CI step that runs a server and executes 'k6 run script.js' to test proto loading, or refactor unit tests to use separate processes. Review the existing test files for gRPC and the CI configuration (e.g., GitHub Actions workflows) to determine the best approach.