grafana/k6

Update goquery and add new Single method to `k6/html`

Open

#2,161 opened on Oct 5, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (30,564 stars) (1,537 forks)batch import
featuregood first issuelower prio

Description

https://github.com/PuerkitoBio/goquery/commit/0126a1fd88fe40e3de18dd677e094b46e23d0cb9 added a new method to optimize getting only the first (single) element from a matcher which might be useful for users as well.

Contributor guide

Tech stack
go
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Gok6/html packagegoquery library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the linked goquery commit (0126a1fd88fe40e3de18dd677e094b46e23d0cb9) to understand the new Single method. Update the goquery dependency in k6's go.mod, then add a new Single method in the k6/html package (likely in /js/modules/k6/html) that wraps goquery's Single. Ensure tests and documentation are updated.