grafana/grafana

Pyroscope/flamegraph: Move "other" out of the TOP table and explain it better

Open

#110677 opened on Sep 5, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (73,744 stars) (13,868 forks)batch import
area/panel/flame-graphgood first issueinternalkind/enhancement

Description

Why is this needed:

Especially in larger deployments and queries over wider time windows. The "other" node becomes the biggest self contributor to resource consumption. Esp. its prominent position in the top table is confusing:

What would you like to be added:

While it is mathematically correct, it is not helpful to list "other" in the top table, as it doesn't show an actionable resource consumption.

In Pyroscope's flamegraph query endpoints we limit the size of the flamegraph to the maxNodes parameters, and we only show the TOP maxNodes total stacktraces. Everything else will be aggregated into "others".

So rather than showing "other" in the table we should filter it in the table and show it under the table:

> A total of "x" has been truncated and is represented by "other" in the flamegraph. Each truncated stacktrace had a total resource consumption of "y".

X: The self/total value of other (they should be matching)
Y: The minimum value of total in the flame graph.

It should still have the icons for sandwich view and for highlight in flamegraph.

Contributor guide

Tech stack
typescriptreact
Domain
frontendobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the flamegraph table component in the Grafana frontend (likely under public/app/plugins/panel/pyroscope). Modify the table rendering logic to exclude the 'other' row from the top table and display a message below the table explaining the truncation, as described in the issue. Ensure the sandwich view and flamegraph highlight icons are still available for the 'other' entry. Test the change with sample flamegraph data to verify correctness.