gpbl/denormalizr

Support memoization

Open

#10 opened on Jun 8, 2016

View on GitHub
 (11 comments) (5 reactions) (0 assignees)JavaScript (24 forks)github user discovery
enhancementhelp wantednew feature

Repository metrics

Stars
 (229 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In my mind, denormalizr is most useful when passing large nested objects to a component using connect. But currently it always returns a new object, so the component re-renders on every action.

denormalize should always return the same (strictly equal) result unless:

  1. The root object is different
  2. Any of the associations in the schema are different

I believe this could be accomplished fairly simply using a cache of denormalized resources.

Contributor guide

Research direction
Implement a memoization cache in denormalize to return the same object reference when the inputs are unchanged. Research existing memoization libraries or patterns in JavaScript.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75