gothinkster/vue-realworld-example-app

VTag: Use computed property for router link

Open

#194 opened on Sep 3, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (4,037 stars) (1,288 forks)batch import
difficulty:easygood first issuetype:enhancement

Description

<router-link
  :to="{ name: 'home-tag', params: { tag: name } }"
  :class="className"
>

Ideally, { name: 'home-tag', params: { tag: name } } should be a computed property and then used like:

<router-link
  :to="homeLink"
  :class="className"
>

Related resources:

Contributor guide

Tech stack
javascriptvue
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vue.js basicscomputed properties
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate the VTag component file (likely in src/components/). Identify the current router link usage with inline object. Create a computed property called 'homeLink' returning the route object { name: 'home tag', params: { tag: name } }. Replace the inline object with the computed property in the template. Ensure that the computed property is reactive to changes in 'name'. Test locally to verify navigation still works. No PRs or discussions exist, so no additional context from previous work.