allow setting the faraday adapter to use
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Start at the Google::Apis::ClientOptions.default entry point and trace how the Faraday client selects its adapter. Check the existing client configuration and adapter-related tests, then verify that setting :adapter to :httpx or :net_http_persistent changes the default adapter without breaking the existing behavior.
Written by the indexing model from the issue text.
Description
The application I work on uses httpclient and relies on its persistent connection feature and request hedging to keep p99 google storage uploads to a minimum. v1 changed to faraday, which is understandable, but the default faraday adapter uses net-http, which does not do persistent requests, and would severely limit our ability to seamlessly upgrade.
This patch introduces a new client option, :adapter, which allows setting a default adapter (faraday has several) which supports persistent connections via:
Google::Apis::ClientOptions.default.adapter = :httpx # or
:net_http_persistent
- Dominant language
- Ruby
- Stars
- 2.9k
- Forks
- 888
- Avg merge
- 8m
- Merged PRs (30d)
- 241
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from googleapis/google-api-ruby-client
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
googleapis/google-api-ruby-client#28001 · 5 reactions ·
-
googleapis/google-api-ruby-client#27757 · 1 assignee ·
-
googleapis/google-api-ruby-client#27758 · 1 assignee ·
-
googleapis/google-api-ruby-client#27759 · 1 assignee ·
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
googleapis/google-api-ruby-client#26399 ·
All issues in googleapis/google-api-ruby-client
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
hanami/hanami-cli#449 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
resque/resque-scheduler#826 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100