google/turbinia

Update unittests executing external binaries

Open

#1,191 opened on Nov 18, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (170 forks)github user discovery
enhancementgood first issuetesting

Repository metrics

Stars
 (789 stars)
PR merge metrics
 (PR metrics pending)

Description

We had a few tests that were calling out to third-party binaries and were also taking a long time to run. These were commented out in https://github.com/google/turbinia/pull/1133/files. We should find a way to test these modules without calling the binaries directly.

Contributor guide

Research direction
Locate the commented out tests in PR #1133 and identify the external binaries they call. Then explore mocking or dependency injection techniques to simulate those binaries in tests.
Tech stack
python
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Pythonunit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70