google/rejoiner

Schema Modification does not work on Input types

Open

#70 opened on Feb 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (152 forks)batch import
help wanted

Repository metrics

Stars
 (3,647 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello,

We are trying to remove a field on an input by doing SchemaModification, but from this code it looks like proto modification only works on GraphQLObjectType instead of GraphQLInputObjectType:

https://github.com/google/rejoiner/blob/cedc123c18918d8c090543a4236ee344d2dbffeb/rejoiner/src/main/java/com/google/api/graphql/rejoiner/ProtoRegistry.java#L196-L206

Is there any chance we can add support for type modification on the input type?

Contributor guide

Research direction
Examine the linked code section in ProtoRegistry.java and modify the schema modification logic to also handle GraphQLInputObjectType.
Tech stack
java
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGraphQLProtobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60