google/rejoiner

Schema Modification does not work on Input types

Open

#70 opened on Feb 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (3,647 stars) (152 forks)batch import
help wanted

Description

Hello,

We are trying to remove a field on an input by doing SchemaModification, but from this code it looks like proto modification only works on GraphQLObjectType instead of GraphQLInputObjectType:

https://github.com/google/rejoiner/blob/cedc123c18918d8c090543a4236ee344d2dbffeb/rejoiner/src/main/java/com/google/api/graphql/rejoiner/ProtoRegistry.java#L196-L206

Is there any chance we can add support for type modification on the input type?

Contributor guide

Tech stack
javagraphqlgrpc
Domain
apibackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaGraphQLgRPC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue points to ProtoRegistry.java lines 196-206 where only GraphQLObjectType is handled. To add support for Input types, one needs to modify the ProtoModification logic to also apply to GraphQLInputObjectType. Check the ProtoModification interface and how it's used for objects, then extend to input types. Look at the GraphQL schema generation code to understand how input types are built and registered.
Schema Modification does not work on Input types · google/rejoiner#70 | Good First Issue