google/python-fire

Logging messages don't using logging

Open

#353 opened on Aug 26, 2021

View on GitHub
 (4 comments) (2 reactions) (0 assignees)Python (1,418 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (26,214 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/google/python-fire/blob/c1266d0dbb2114514fcf8be62044344b5a51c733/fire/core.py#L239 https://github.com/google/python-fire/blob/c1266d0dbb2114514fcf8be62044344b5a51c733/fire/core.py#L287

When I get the help message, includes INFO: messages like: INFO: Showing help with the command {cmd}

I would like such logging messages to use Python's logging framework which would allow me to suppress and redirect such messages.

Contributor guide

Research direction
Inspect the lines in fire/core.py that produce INFO messages and replace them with calls to Python's logging module, ensuring that the logger is configured appropriately to allow suppression or redirection.
Tech stack
python
Domain
clideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPython logging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70