google/open-location-code

Add pylint checks for Python code

Open

#327 opened on May 6, 2019

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Java (500 forks)batch import
help wantedpython

Repository metrics

Stars
 (3,945 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Python got code formatting added in #326 - in addition we should add pylint checking as well to pick up common errors.

We could adopt the pylintrc from the YAPF project.

Note: The pylintrc and the YAPF style will need to agree - for example the indentation in YAPF is four spaces and the above pylintrc uses two spaces.

It will need to be added to the travis.yml, and all the issues (there will be lots) addressed.

Contributor guide

Research direction
Inspect the existing pylintrc from YAPF and integrate it into the project's Travis CI configuration, then fix all pylint errors in the Python code.
Tech stack
python
Domain
testingdevops
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40