google/open-location-code

Update JSON file access by karma/jasmine tests

Open

#324 opened on May 3, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (3,945 stars) (500 forks)batch import
help wantedjs

Description

Existing node JS tests (in js/test) use a combination of gulp and phantomjs to run.

phantomjs is now unsupported (and seems to be a pain to get working locally) so it would be good to refactor the tests to use karma/jasmine.

I've had a quick go at this but got stuck trying to get the test functions to access the CSV files. (If we have to we could convert them to JSON as part of the test script.)

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript testing experienceFamiliarity with Karma/JasmineFile I/O in Node
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the current test setup in `js/test` to understand how gulp and phantomjs are used. Examine the test functions that need to access CSV files and determine the best way to either allow direct file access in karma/jasmine or convert the CSV files to JSON format. Look for any related comments in the issue for guidance from maintainers.