google/material-design-lite

Add focus trapping to v1 side-nav

Open

#4951 opened on Dec 1, 2016

View on GitHub
 (3 comments) (0 reactions) (1 assignee)HTML (32,173 stars) (4,926 forks)batch import
AccessibilityLayouthelp wantedv1-bug

Description

The v1 side-nav is missing focus trapping, so it's currently possible to tab out of the drawer and into the background content, while it's open. We should implement focus trapping to prevent that from happening.

Contributor guide

Tech stack
htmlcssjavascript
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptDOM manipulationaccessibility
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Focus trapping prevents keyboard focus from leaving an open drawer. In this issue, the side nav drawer lacks focus trapping, allowing users to tab out. To implement, first locate the side nav component (likely in side nav.js or related files). Study the drawer's open/close logic. Use a common focus trapping pattern: when drawer opens, save the last focused element; intercept Tab key events within the drawer; loop focus among tabbable elements inside. Ensure the trap releases on close. Check for any existing discussions or PRs that attempted this (none currently). After implementing, test manually with keyboard navigation.