google/gvisor

Support CLOCK_BOOTTIME

Open

#218 opened on Apr 29, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (12,713 stars) (1,061 forks)batch import
area: compatibilitygood first issuepriority: p3type: enhancement

Description

We could likely make CLOCK_BOOTTIME equivalent to CLOCK_MONOTONIC, as CLOCK_MONOTONIC already includes time spent not running during save / restore, which is the closest thing we have to "suspend".

https://github.com/google/gvisor/blob/8f4634997bd97810a85a70b71f000378d9db2e55/pkg/sentry/kernel/timekeeper.go#L119-L129

Contributor guide

Tech stack
go
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programminggVisor architectureLinux clock handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
First, examine the current implementation of CLOCK MONOTONIC in pkg/sentry/kernel/timekeeper.go (lines 119-129) to understand how it works. Then, create a similar handling for CLOCK BOOTTIME, ensuring it behaves identically to CLOCK MONOTONIC. Additionally, check if there are any other references to clock IDs in the codebase that need to be updated.