google/gvisor

Combine similar syscall tests

Open

#1,640 opened on Jan 22, 2020

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Go (1,061 forks)batch import
area: testsexportedgood first issuepriority: p2type: bug

Repository metrics

Stars
 (12,713 stars)
PR merge metrics
 (PR metrics pending)

Description

Some gVisor syscall tests are almost identical and can easily be combined. This requires changes to the parameterized test parameter.

Example tests are UDPBroadcastSendRecvOnSocketBoundToAny and UDPBroadcastSendRecvOnSocketBoundToBroadcast in socket_ipv4_udp_unbound_external_networking.cc.

Contributor guide

Research direction
Identify identical test patterns in socket ipv4 udp unbound external networking.cc and refactor them into parameterized tests.
Tech stack
gocpp
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++gVisor testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70