google/gvisor

[checklocks]: source file and line number sometimes not printed

Open

#11203 opened on Nov 21, 2024

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Go (12,713 stars) (1,061 forks)batch import
good first issuestatus: help wantedtype: bug

Description

Description

sometimes I see:

-: return with unexpected locks held (locks: &({param:f}.mu) exclusively)

notice the usual file name and line number is replaced by -.

Steps to reproduce

go: downloading gvisor.dev/gvisor v0.0.0-20241120231458-0add1d20fa0c

I haven't been able to extract a simple repro (the fact that I can't tell where the error is happening makes it harder). I happen to believe these are false positive as well but it's hard to prove without knowing what it's unhappy about :-)

runsc version

docker version (if using docker)

uname

No response

kubectl (if using Kubernetes)

repo state (if built from source)

No response

runsc debug logs (if available)

Contributor guide

Tech stack
go
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Go programmingconcurrency conceptsgvisor internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the checklocks code in gvisor to find where error messages are constructed. The file and line number appear as ' ' so look for cases where file/line information is missing or overridden. Check the logic that determines whether to include file/line in the error string. Consider adding logging or debug output to capture the stack trace when the error occurs.