google/googletest

[Bug]: CMake FetchContent_* does not work with GTest as dependency name on Windows

Open

#4,384 opened on Oct 3, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (38,603 stars) (10,772 forks)batch import
help wanted

Description

Describe the issue

CMake FetchContent_* does not work with GTest as dependency name. If the dependency name is changed to googletest or to foobar everything works as expected. This is very unfortunate because GTets is used in the find_package command of CMake and if this fails the FetchContent mechanism can be used as fallback. But not on windows as you can see here:

https://github.com/ObiWahn/googletest-CMake-FetchContent/pull/1

Steps to reproduce the problem

https://github.com/ObiWahn/googletest-CMake-FetchContent/pull/1/files

What version of GoogleTest are you using?

v.1.14.0

What operating system and version are you using?

windows

What compiler and version are you using?

msvc / clang

What build system are you using?

cmake 3.27.6

Additional context

No response

Contributor guide

Tech stack
cpp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CMakeFetchContentWindows build tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the issue reported in googletest issue #4384 and the related temporary PR at https://github.com/ObiWahn/googletest CMake FetchContent/pull/1. The problem occurs when using CMake's FetchContent with the dependency named 'GTest' on Windows. Review the CMake modules in the googletest repository, particularly the handling of find package and FetchContent integration, to understand why certain names cause failures. The fix may involve renaming or adding logic to handle the 'GTest' name collision.