Inconsistency between indent level in AOSP and non-aosp

Open

#1,189 opened on Nov 18, 2024 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: java
Domain: tooling

Research direction

Reproduce the report with the Test.java example and run google-java-format both with and without --aosp. Compare the continuation-string indentation with the expected AOSP output, then inspect the formatter behavior responsible for that difference. Done means the AOSP result is clarified or corrected and covered by an appropriate regression test.

Written by the indexing model from the issue text.

Description

I am not entirely sure wether this is the intended behavior, so here is an issue. The the continuation of the long string doesn't indent with 8 spaces from the previous line which I would expect in AOSP.

Test.java

public class Test {
    String s = "asdfasdfasdfasdf asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

❯ java -jar ~/Downloads/google-java-format-1.24.0-all-deps.jar Test.java
public class Test {
  String s =
      "asdfasdfasdfasdf"
          + " asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

❯ java -jar ~/Downloads/google-java-format-1.24.0-all-deps.jar --aosp Test.java
public class Test {
    String s =
            "asdfasdfasdfasdf"
                + " asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

I would expect the following output using AOSP style

public class Test {
    String s =
            "asdfasdfasdfasdf"
                    + " asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

I raised this issue in the spotless repo because I figured that spotless not indenting the same way as GJF would be a spotless bug.

If this is the intended behavior, please let me know, so that I can reraise the issue at spotless.

Dominant language: Java
Stars: 6.2k
Forks: 936
Avg merge: 6m
Merged PRs (30d): 3

Getting set up

Read the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Choose Directory dialog returns ".." after selecting the parent row Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 84/100

rstudio/rstudio#18958 · Opened Sep 25, 2026

Maintainers usually reply within 1 day
[CI Failure] Flaky: ManageDataDialogTests bUnit JSInterop hang on IconCheckbox.initializeIconCheckboxKeyboard call Open

ci-failure-cause test-failure

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

microsoft/aspire#20493 · Opened Sep 25, 2026

Maintainers usually reply within 1 day
Automatically select entire title when renaming Open

enhancement

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

nextcloud/notes-android#3367 · Opened Sep 25, 2026

Maintainers usually reply within 1 day
[Feature Request] Memory Tagging Extension (MTE) asynchronous mode Open

Feature

Difficulty 2/5 1-3 hours Newbie friendliness 68/100

MuntashirAkon/AppManager#2058 · Opened Sep 25, 2026
SarifLogger: artifactLocation.uri is not properly encoded for file names containing '#', '?', or '%' Open

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

checkstyle/checkstyle#21721 · Opened Sep 25, 2026

Maintainers usually reply within 1 day

More Java issues