Type of Object.groupBy and its callback wrong

Open Beginner friendly
#187 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
java, javascript
Domain
api, web-dev

Research direction

Start with the referenced externs/es6.js at line 2456 and inspect how Object.groupBy and its callback are declared. Update the signatures so the callback returns a string, symbol, or number and verify that generated or checked Elemental2 types expose that shape without producing multiple incorrect signatures.

Written by the indexing model from the issue text.

Description

https://github.com/google/closure-compiler/blob/f2cc20715e86c7dafd6de0f9e06eb2da693903f3/externs/es6.js#L2456

produces multiple signatures that are incorrect. Looks like it was interpreted as

[ function(T, number=): string ] |symbol|number

rather than

function(T, number=): [ string|symbol|number ]

Dominant language
Java
Stars
170
Forks
41
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from google/elemental2

All issues in google/elemental2

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.