google/comprehensive-rust

Add CI job that ensures every translation builds

Open

#2,539 opened on Jan 4, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (2,009 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (32,954 stars)
PR merge metrics
 (Avg merge 9d 23h) (36 merged PRs in 30d)

Description

Currently, I have to add each language individually to the branch protection rules for main. This a problem since we can merge PRs which fail later when building the translations for publishing.

I think we can handle this by adding a new CI job which waits on every translation and only succeeds when they all succeed.

Originally posted by @mgeisler in https://github.com/google/comprehensive-rust/issues/2531#issuecomment-2571282773

Contributor guide

Research direction
Study the existing GitHub Actions workflows in .github/workflows, identify the translation build jobs, and add a new job that depends on all translation jobs using the 'needs' keyword and 'always()' condition to check success.
Tech stack
rust
Domain
ci cddevops
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitHub ActionsYAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60