google/comprehensive-rust

Rewrite speaker note system

Open

#1,232 opened on Sep 22, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (32,954 stars) (2,009 forks)batch import
good first issuehelp wanted

Description

The speaker-notes.js file is a little home-grown system for injecting speaker notes to the pages.

I would like to rewrite this to use a more modern development style:

  • we should minimize the code when publishing the course
  • we should make the label ("Speaker Notes") translatable!
  • we could perhaps use a library for some of the state logic?
  • we could take advantage of https://github.com/google/mdbook-i18n-helpers/issues/70 when it's ready to do less on the fly DOM manipulation

Contributor guide

Tech stack
javascript
Domain
documentationinternationalizationlocalization
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with speaker notes.jsJavaScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by reading the current speaker notes.js file to understand the existing DOM manipulation and state logic. Investigate the linked mdbook i18n helpers issue #70 for planned features that could simplify the rewrite. Look into lightweight JavaScript libraries for state management that would minimize code size. Ensure the new system supports making the 'Speaker Notes' label translatable, likely by integrating with the i18n helpers.