google/closure-compiler

Exclude pattern causes error if directory doesn't exist

Open

#608 opened on Sep 5, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (7,176 stars) (1,197 forks)batch import
help wanted

Description

java -jar compiler.jar '!bar/**.js'

fails with ERROR - read error. (regardless of what other patterns are there) if the bar directory does not exist.

If the directory does not exist, it should ignore it.

(This should also be the behavior of include patterns, IMO.)

Contributor guide

Tech stack
java
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaFile I/O
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the file pattern handling code in the Closure Compiler, likely in the Compiler class. The issue is that an exclude pattern for a non existent directory causes an error. The fix should check if the directory exists before trying to read it and skip it if not.