google/closure-compiler

Exclude pattern causes error if directory doesn't exist

Open

#608 opened on Sep 5, 2014

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Java (1,197 forks)batch import
help wanted

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (PR metrics pending)

Description

java -jar compiler.jar '!bar/**.js'

fails with ERROR - read error. (regardless of what other patterns are there) if the bar directory does not exist.

If the directory does not exist, it should ignore it.

(This should also be the behavior of include patterns, IMO.)

Contributor guide

Research direction
Investigate the file pattern handling in the closure compiler's source code. Focus on how exclusion patterns are parsed and applied, and modify the logic to skip non existent directories instead of throwing an error.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60