google/closure-compiler

String.fromCharCode optimization

Open

#3,606 opened on May 27, 2020

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Java (1,197 forks)batch import
P4featgood first issue

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

I used: https://closure-compiler.appspot.com/home

Input code: document.write(String.fromCharCode(115));

Expected output: document.write("s")

Actual output: document.write(String.fromCharCode(115));

I expected the String.fromCharCode function to be removed to just the resulting character.

Contributor guide

Research direction
Implement a pass that detects calls to String.fromCharCode with a single numeric argument and replaces them with the corresponding character literal. Use the existing compiler infrastructure for peephole optimizations.
Tech stack
javascriptjava
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75