google/closure-compiler

Option to fail on warnings

Open

#3,451 opened on Aug 13, 2019

View on GitHub
 (4 comments) (2 reactions) (0 assignees)Java (1,197 forks)batch import
help wantedinternal-issue-created

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

I would like to propose an option that could make the compiler fail if at least one warning is encountered, regardless of errors and exit with a non-zero exit code.

This could be a simple flags such as --fail-on-warnings or a more sophisticated setting like --error-level that could introduce more granular control, i.e. still exit with 0 if compilation failed with errors.

Use case for this is either a purist approach when no warnings are tolerated or code quality control CI job that verifies new code with --checks-only.

Contributor guide

Research direction
Look at the existing command line flag parsing in the compiler and modify the warning handling to exit with non zero when a warning occurs if the flag is set.
Tech stack
javascriptjava
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80