google/closure-compiler

I think parseInt radix should be optional

Open

#3,230 opened on Feb 12, 2019

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (1,197 forks)batch import
P4good first issueinternal-issue-createdtriage-done

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

I understand why this is. But if feels like a very old legacy issue...

https://github.com/google/closure-compiler/blob/b29d09f56b56e5b3ea78ba0317ae579b837fd821/externs/es3.js#L289-L300

Nowdays all browser use radix 10 as default and has done so for a long time. And the likelihood of someone starting the number with 0 and using IE8 is very slim. Many have stop supporting old browsers

* @param {number=} base

Contributor guide

Research direction
Review the ECMAScript specification for parseInt radix default behavior and examine how the Closure Compiler externs affect warnings. Consider browser compatibility implications and test changes.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70