google/closure-compiler

I think parseInt radix should be optional

Open

#3,230 opened on Feb 12, 2019

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (7,176 stars) (1,197 forks)batch import
P4good first issueinternal-issue-createdtriage-done

Description

I understand why this is. But if feels like a very old legacy issue...

https://github.com/google/closure-compiler/blob/b29d09f56b56e5b3ea78ba0317ae579b837fd821/externs/es3.js#L289-L300

Nowdays all browser use radix 10 as default and has done so for a long time. And the likelihood of someone starting the number with 0 and using IE8 is very slim. Many have stop supporting old browsers

* @param {number=} base

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptfamiliarity with closure compiler externs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests making parseInt radix parameter optional. Discussion points to the externs file at https://github.com/google/closure compiler/blob/b29d09f56b56e5b3ea78ba0317ae579b837fd821/externs/es3.js lines 289-300. The change would involve modifying the @param annotation to make base optional, but there are concerns about legacy behavior and browser compatibility. Examine the discussion for maintainer feedback and any alternative solutions proposed.