google/closure-compiler

Jasmine Externs are out of Date

Open

#3,045 opened on Aug 6, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (7,176 stars) (1,197 forks)batch import
Externshelp wanted

Description

I've found that many Closure externs are out of date for Jasmine. Specifically, I see:

  • Many custom matcher types are missing, including:
    • CustomMatcherFactories
    • MatchersUtil
    • CustomEqualityTester
    • CustomMatcher
  • Jasmine's pretty print utility is missing (jasmine.pp())
  • Most matcher functions (toBe(), toEqual(), etc.) accept an optional string to use as an error message if the expectation fails. This is also missing.
  • Likely others...

Without these types, custom matchers are basically impossible. Would be great to see these types updated.

See: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jasmine/index.d.ts

Contributor guide

Tech stack
javascript
Domain
testingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsClosure compiler externsJasmine testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Study the existing Closure externs for Jasmine in the closure compiler repository (likely in the externs directory). Compare with the latest Jasmine version's API, using the DefinitelyTyped types/jasmine/index.d.ts as a reference. Identify missing types such as CustomMatcherFactories, MatchersUtil, CustomEqualityTester, CustomMatcher, jasmine.pp(), and the optional string parameter in matchers. Then add or update the externs file accordingly.
Jasmine Externs are out of Date · google/closure-compiler#3045 | Good First Issue