google/closure-compiler

Closure compiler fails to parse "interface" as parameter name

Open

#2,852 opened on Mar 15, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Java (1,197 forks)batch import
P3Parserhelp wanted

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

Closure compiler is unable to parse "interface" being used as the name of a parameter. This code does successfully execute in Chrome, Safari, and Firefox devtools.

(function x(interface) { console.log(interface); })('test')

https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540output_file_name%2520default.js%250A%252F%252F%2520%2540formatting%2520pretty_print%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A(function%2520x(interface)%2520%257B%2520console.log(interface)%253B%2520%257D)('test')

Contributor guide

Research direction
Inspect the JavaScript parser code in the closure compiler to find where parameter names are processed. Look for how reserved words are handled and add 'interface' to the list of allowed parameter names.
Tech stack
javascriptjava
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75