google/closure-compiler

require with a substitution-free template string is not recognized by process_common_js_modules

Open

#2,626 opened on Aug 21, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (1,197 forks)batch import
P2help wanted

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

I'm using the compiler with the process_common_js option set to true.

The following code works fine:

/** @const */
const update = require( "./update.js" );

However, switching to a substitution-free template string breaks:

/** @const */
const update = require( `./update.js` );

resulting in:

src/main.js:8: ERROR - variable require is undeclared
const update = require( `./update.js` );
               ^^^^^^^

The code style of the project I'm working on imposes template strings wherever syntactically possible (only object keys get a pass and can use double quotes). Of course, this does include paths in require statements. Sadly, it seems the CommonJS machinery does not recognize such statements as processable.

As a workaround, I can break from the code style but it is clearly not ideal and it would be really nice if the compiler was able to handle this.

Contributor guide

Research direction
Investigate the process common js modules function to see how require calls are parsed and add support for template strings.
Tech stack
javascriptjava
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptJavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60