google/closure-compiler

If someone calls goog.functions.constant(true) warn, and suggest replacing it with goog.functions.TRUE

Open

#1945 opened on Aug 9, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (7,176 stars) (1,197 forks)batch import
enhancementhelp wantedlint

Description

And likewise for false and null.

Contributor guide

Tech stack
javascriptjava
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaClosure Compiler internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Identify the appropriate compiler pass where a warning for `goog.functions.constant` with literal arguments can be added. Look at existing similar checks in the codebase, such as in the `CheckNoSuchMethod` or other warning passes. The error message should be defined in the compiler's message properties. The AST analysis should detect calls to `goog.functions.constant` where the argument is `true`, `false`, or `null`, and suggest replacing with `goog.functions.TRUE`, `FALSE`, or `NULL` respectively. Files like `com.google.javascript.jscomp.CheckSideEffects` or `Warnings.java` may provide patterns to follow.