google/closure-compiler

Compress condition as logical expression

Open

#1,842 opened on Jun 13, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,197 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

Hi,

I wonder if it's possible to shrink an expression like

if (!a)
   c = b;
else
   c =a;

to

c = a || b;

instead of

c = a ? a : b;

You do such tricks already in a logical manner to kick out if-statements, but it would make sense within expressions as well. Or do I miss something, that it should be avoided?

Thanks!

Contributor guide

Research direction
Study existing similar optimizations in the compiler (e.g., PeepholeFoldConstants) and implement a new pass that transforms if else assignment to logical OR expression. Ensure the transformation is safe when side effects are absent.
Tech stack
javajavascript
Domain
compilerstooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60