google/closure-compiler

Turn compareJsDoc on in all unit tests

Open

#1,396 opened on Jan 14, 2016

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (1,197 forks)batch import
help wantedinternal cleanup

Repository metrics

Stars
 (7,176 stars)
PR merge metrics
 (Avg merge 3d 4h) (1 merged PR in 30d)

Description

git grep "compareJsDoc = false" gives:

test/com/google/javascript/jscomp/AmbiguatePropertiesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/AngularPassTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/CheckAccessControlsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/CollapsePropertiesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/CollapseVariableDeclarationsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/DevirtualizePrototypeMethodsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/Es6InlineTypesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/GenerateExportsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/InferJSDocInfoTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/InlinePropertiesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/InlineVariablesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/JsdocToEs6TypedConverterTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/NormalizeTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/OptimizeParametersTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ProcessCommonJSModulesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ProcessDefinesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/RemoveUnusedVarsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/RenameVarsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceIdGeneratorsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceMessagesForChromeTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceMessagesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceStringsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/RuntimeTypeCheckTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/VarCheckTest.java: compareJsDoc = false;

We should eventually turn it on for all of them and remove the compareJsDoc field.

Contributor guide