google/closure-compiler

Turn compareJsDoc on in all unit tests

Open

#1396 opened on Jan 14, 2016

View on GitHub
 (12 comments) (0 reactions) (0 assignees)Java (7,176 stars) (1,197 forks)batch import
help wantedinternal cleanup

Description

git grep "compareJsDoc = false" gives:

test/com/google/javascript/jscomp/AmbiguatePropertiesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/AngularPassTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/CheckAccessControlsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/CollapsePropertiesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/CollapseVariableDeclarationsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/DevirtualizePrototypeMethodsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/Es6InlineTypesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/GenerateExportsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/InferJSDocInfoTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/InlinePropertiesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/InlineVariablesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/JsdocToEs6TypedConverterTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/NormalizeTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/OptimizeParametersTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ProcessCommonJSModulesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ProcessDefinesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/RemoveUnusedVarsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/RenameVarsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceIdGeneratorsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceMessagesForChromeTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceMessagesTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/ReplaceStringsTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/RuntimeTypeCheckTest.java: compareJsDoc = false; test/com/google/javascript/jscomp/VarCheckTest.java: compareJsDoc = false;

We should eventually turn it on for all of them and remove the compareJsDoc field.

Contributor guide

Tech stack
java
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Search for files with 'compareJsDoc = false' using the provided grep command. Remove the line that sets compareJsDoc to false from each listed file. Ensure the unit tests still pass by running the test suite. The files are in test/com/google/javascript/jscomp/ directory. Cross out the ones already done (indicated by ~~ in the body) those are already removed. Focus on the remaining 13 files.