google/benchmark

ICC sysinfo fixes

Open

#754 opened on Jan 16, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (1,539 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (Avg merge 4d 2h) (19 merged PRs in 30d)

Description

sysinfo fails to compile on OSX with ICC due to two issues:

error #2259 is caused by the return value from sysinfo.cc:558 being implicitly cast from unsigned long long to double.

error #177 is caused by methods at sysinfo.cc:112 ValueUnion::GetAsString and sysinfo:114 ValueUnion::GetAsInteger being unused.

To resolve this we should:

  1. add an explicit cast for hz to double
  2. add -wd177 to the ICC compiler flags

Contributor guide

Research direction
Add explicit cast for hz to double in sysinfo.cc line 558 and add wd177 to ICC compiler flags.
Tech stack
cpp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90