google/benchmark

master is broken on Android

Open

#731 opened on Nov 26, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (7,968 stars) (1,539 forks)batch import
bughelp wanted

Description

master version (I tested revision c9311a44e1280853632fe2472345dd04514a2f74) fails to build on Android, with the error:

/Users/marat/benchmark/src/sysinfo.cc:586:21: error: use of undeclared identifier 'getloadavg'
  const int nelem = getloadavg(res.data(), kMaxSamples);
                    ^
1 error generated.

Repro:

git clone https://github.com/google/benchmark.git
cd benchmark
mkdir build && cd build
cmake -DCMAKE_TOOLCHAIN_FILE=/path/to/android/ndk/build/cmake/android.toolchain.cmake -DBENCHMARK_ENABLE_TESTING=OFF ..
make

Contributor guide

Tech stack
cpp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Android NDKCMakecross compilation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the sysinfo.cc file around line 586. The error indicates getloadavg is not available on Android. Consider using a preprocessor directive to conditionally include this code only on platforms that support getloadavg, or implement an alternative for Android. Check the repository's existing platform detection macros. Also review comments in the issue for any suggested solutions.