google/benchmark

Use of cmake 3.6 feature with cmake_minimum_required (VERSION 2.8.12)

Open

#603 opened on May 25, 2018

View on GitHub
 (18 comments) (3 reactions) (1 assignee)C++ (1,539 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (Avg merge 4d 2h) (19 merged PRs in 30d)

Description

https://github.com/google/benchmark/commit/e776aa0275e293707b6a0901e0e8d8a8a3679508 This commit adds list(FILTER SOURCE_FILES EXCLUDE REGEX "benchmark_main\\.cc") line to https://github.com/google/benchmark/blob/master/src/CMakeLists.txt. list(FILTER was introduced in CMake 3.6, however you script sets minimum required CMake version at 2.8.12.

Contributor guide

Research direction
Update the CMake minimum required version or replace the `list(FILTER ...)` with a compatible alternative like `foreach` and `list(APPEND)`. See commit e776aa0 for context.
Tech stack
cpp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CMake basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70