google/benchmark

Add support for Solaris SunPro compiler

Open

#588 opened on May 6, 2018

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C++ (1,539 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (Avg merge 4d 2h) (19 merged PRs in 30d)

Description

While many of the GCC style compiler flags work with the Solaris SunPro compiler the warning settings result in compiler error in release builds. Debug builds result in warnings but complete successful since -Werror is not applied.

I will tackle these minor changes to make compilation work under SunPro.

Contributor guide

Research direction
Investigate the build configuration files (e.g., CMakeLists.txt or Makefile) to locate where warning flags are set. Add conditional logic to skip or modify flags that cause errors on the SunPro compiler.
Tech stack
cpp
Domain
build systemdeveloper experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75