google/benchmark

Add support for Solaris SunPro compiler

Open

#588 opened on May 6, 2018

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C++ (7,968 stars) (1,539 forks)batch import
bughelp wanted

Description

While many of the GCC style compiler flags work with the Solaris SunPro compiler the warning settings result in compiler error in release builds. Debug builds result in warnings but complete successful since -Werror is not applied.

I will tackle these minor changes to make compilation work under SunPro.

Contributor guide

Tech stack
cpp
Domain
build systemdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ build system knowledgeFamiliarity with SunPro compiler flags
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue is to add support for the Solaris SunPro compiler. The project uses CMake as its build system. Research should focus on how other compiler specific flags are conditionally applied in the CMakeLists.txt files. For example, examine the handling of GCC and MSVC flags and replicate the pattern for SunPro. The main goal is to ensure that warning flags do not cause errors in release builds while still being effective in debug builds.