google/benchmark

Dynamically initialized globals are problematic

Open

#233 opened on Jun 2, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (1,539 forks)batch import
help wanted

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (Avg merge 4d 2h) (19 merged PRs in 30d)

Description

we have a few global non-PODs in tests. these should be removed.

https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

Contributor guide

Research direction
Identify all non POD global variables in test files, understand their initialization dependencies, and refactor them to be locally scoped or function static to avoid dynamic initialization issues. Follow the Google C++ Style Guide recommendations.
Tech stack
cpp
Domain
testingbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75