google/benchmark

[FR] Allow modification of perf attributes

Open

#1,897 opened on Jan 6, 2025

View on GitHub
 (8 comments) (2 reactions) (0 assignees)C++ (1,539 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (Avg merge 4d 2h) (19 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

I have a multi-threaded benchmark where I'd like the performance counters to only measure the main thread.

Describe the solution you'd like

Setting the inherit attribute to false instead of true before passing the struct to perf_event_open would solve my issue. Some sort of configuration option which allows me to set this would be ideal. Maybe this can be extended to other attributes as well instead of hardcoding them.

Describe alternatives you've considered

Currently, I have to set it to false and recompile google benchmark.

Contributor guide

Research direction
Implement a configuration option to set perf event open attributes, starting by adding a member to the PerfCounters object and passing it to perf event open. Allow users to specify attributes like inherit via a command line flag or programmatic API.
Tech stack
cpp
Domain
performance
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50