google/benchmark

[BUG] some tests segfault sporadically on OSX

Open

#1,279 opened on Nov 10, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C++ (1,539 forks)batch import
bughelp wantedos:osx

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (Avg merge 4d 2h) (19 merged PRs in 30d)

Description

Describe the bug

System Which OS, compiler, and compiler version are you using:

  • OS: OSX (bigsur)
  • Compiler and version: Apple Clang 13.0.0

To reproduce

  1. at HEAD
  2. cmake --build "build" --config Debug
  3. cmake -E chdir "build" ctest ---build-config Debug

Expected behavior All tests should pass at HEAD

Actual behavior The following tests FAILED: 47 - register_benchmark_test (SEGFAULT) 59 - user_counters_tabular_test (SEGFAULT)

Keep re-running the tests (step 3), one or both of them could pass occasionally. There seems to be some level of indeterminism here but I haven't been able to track down.

Contributor guide

Research direction
Reproduce the segfault on OSX, use AddressSanitizer or Valgrind to find the cause. Check for uninitialized memory or race conditions.
Tech stack
cpp
Domain
testingperformance
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitCMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55