google/benchmark

[FR] LTO should default to true

Open

#1,022 opened on Aug 18, 2020

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C++ (1,539 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (7,968 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. BENCHMARK_ENABLE_LTO=true is recommended by the README.md. It should likely be the default if we think it is that important.

Contributor guide

Research direction
Find the CMake option definition for BENCHMARK ENABLE LTO in the CMakeLists.txt file and change its default value from false to true.
Tech stack
cpp
Domain
performance
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90