google-gemini/gemini-cli

test(a2a-server): migrate process.env to vi.stubEnv() per GEMINI.md conventions

Open

#19826 opened on Feb 21, 2026

View on GitHub
 (8 comments) (0 reactions) (1 assignee)TypeScript (103,992 stars) (13,657 forks)batch import
Stalearea/platformgood first issuehelp wantedkind/bugkind/customer-issuepriority/p3status/bot-triaged

Description

Description

Per the testing conventions documented in GEMINI.md:

When testing code that depends on environment variables, use vi.stubEnv('NAME', 'value') in beforeEach and vi.unstubAllEnvs() in afterEach. Avoid modifying process.env directly as it can lead to test leakage and is less reliable.

Several test files in packages/a2a-server/ still use direct process.env manipulation:

  • src/commands/init.test.ts (1 direct assignment)
  • src/config/config.test.ts (~8 direct assignments/deletions)
  • src/http/app.test.ts (3 direct assignments/deletions)

Proposed fix

Replace all direct process.env writes and deletes with vi.stubEnv() / vi.unstubAllEnvs() following the pattern documented in GEMINI.md.

I'd be happy to submit a PR for this.

Contributor guide

Tech stack
typescriptvitest
Domain
testingbackend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with GEMINI.md conventionsbasic understanding of Vitest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Replace direct process.env assignments and deletions in the three test files (init.test.ts, config.test.ts, app.test.ts) with vi.stubEnv() in beforeEach and vi.unstubAllEnvs() in afterEach. Follow the pattern documented in GEMINI.md. No additional code changes are required.