google-deepmind/pysc2

bin/play.py --replay should accept urls

Open

#139 opened on Jan 10, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (7,868 stars) (1,162 forks)batch import
help wanted

Description

bin/play.py will replay a replay file, but only from local disk. It'd be nice if it was given a url it'd download it to memory and pass the data to the game without having to write it to disk somewhere.

Contributor guide

Tech stack
python
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythonunderstanding of bin/play.py
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the source code of bin/play.py to see how it currently loads replay files from disk. Implement a feature that accepts a URL, downloads the replay using urllib (or requests), and passes the in memory data to the game function without saving to disk. Ensure the command line argument parsing supports both file paths and URLs.
bin/play.py --replay should accept urls · google-deepmind/pysc2#139 | Good First Issue