golang/go

x/tools/gopls: source.addTest: emit t.Context() when module is Go 1.24+

Open

#79,647 opened on May 25, 2026

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Go (133,883 stars) (19,008 forks)batch import
Toolsgoplshelp wanted

Description

Proposal

The source.addTest code action ("Add test for FUNC") passes context.Background() whenever the function under test takes context.Context as its first parameter:

got := a.Foo(context.Background(), tt.in)

When the module's go.mod declares Go 1.24 or later, the generated scaffolding should use t.Context() instead:

got := a.Foo(t.Context(), tt.in)

Implementation

I have a draft CL ready. It gates on versions.AtLeast(fileVersion, versions.Go1_24); older modules keep the current context.Background() behavior.

Contributor guide

Tech stack
go
Domain
developer experiencetesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programming languagegopls internalsGo module versioning
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the source.addTest code action implementation in the gopls source (likely in internal/lsp/source or similar). Examine how it currently generates test scaffolding with context.Background(). Understand the Go version detection mechanism using versions.AtLeast and the Go1 24 constant. Review the draft CL (if linked) or follow the discussion in the issue to understand the desired change. Ensure familiarity with the testing.T.Context() method introduced in Go 1.24.