golang/go

x/tools/internal/typesinternal: FileQualifier needs to add imports, and reject unnameable types

Open

#75604 opened on Sep 25, 2025

View on GitHub
 (8 comments) (0 reactions) (1 assignee)Go (133,883 stars) (19,008 forks)batch import
NeedsFixRefactoringToolshelp wanted

Description

The job of FileQualifier is to help TypeString print types in valid Go syntax, respecting the local lexical environment and the file's set of existing imports. However, in general this may require (a) adding new imports for types belonging to packages that are not currently imported and (b) reporting that the task cannot be completed because one or more types are members of another package and are inaccessible either because they are unexported or because that package is internal relative to this one.

The task of this issue is to augment FileQualifier to accumulate a list of import edits, and an error when it sees a type it cannot print. This should fix a number of bugs across all our refactoring tools. It could also use some good tests.

Contributor guide

Tech stack
go
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingUnderstanding of Go type systemFamiliarity with x/tools internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requires modifying the FileQualifier type in the x/tools/internal/typesinternal package. The goal is to accumulate import edits and report errors when types cannot be printed (e.g., unexported or internal packages). Review the current implementation of FileQualifier in that package, understand how TypeString interacts with it, and then implement the two new capabilities. Add comprehensive tests for various scenarios, including importing new packages and handling unnameable types. The linked PRs or comments in the issue may provide additional context.