golang/go

x/tools/go/analysis/passes/modernize: minmax: suggest deletion of redundant min and max functions

Open

#75589 opened on Sep 24, 2025

View on GitHub
 (13 comments) (1 reaction) (0 assignees)Go (133,883 stars) (19,008 forks)batch import
NeedsInvestigationRefactoringToolshelp wanted

Description

Proposal Details

I proposal to add a checker to check whether user has impl a max/min instead of builtin max/min. And suggest user to replace with builtin max/min. search

language:go "func min"

in github with get about 142k result in code.

Contributor guide

Tech stack
go
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingGo analysis frameworkAST manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the existing checkers in the modernize pass to understand the pattern for suggesting replacements. Analyze the Go AST for function declarations named 'min' or 'max' that have the same signature as built in min/max. Consider edge cases like different return types, variadic versions, or use in older Go versions. Check comments in the issue for any additional constraints or examples.