golang/go

x/review/git-codereview: asks for password when cookie is required

Open

#74689 opened on Jul 21, 2025

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (133,883 stars) (19,008 forks)batch import
NeedsFixToolProposalhelp wanted

Description

Go version

go1.24.1 darwin/arm64

Output of go env in your module/workspace:

AR='ar'
CC='clang'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='clang++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/bracken/Library/Caches/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/Users/bracken/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/j6/l0vmp0f15cg2_0jz9zcm2jvh0000gn/T/go-build2342916578=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/dev/null'
GOMODCACHE='/Users/bracken/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/bracken'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/bracken/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.24.1'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

I installed golang.org/x/review/git-codereview using the instructions at https://go.dev/doc/contribute#git-codereview_install because I was using a different machine to make changes to a review I had received feedback on.

What did you see happen?

git codereview mail prompted me for a username, and then for a password which doesn't exist.

What did you expect to see?

git codereview mail to either work or tell me what is wrong.

Contributor guide

Tech stack
go
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Go setupunderstanding of Gerrit authentication
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how git codereview prompts for credentials. Check if the issue is related to missing cookie file or misconfigured GOAUTH. Look at the source code in the x/review repository for authentication handling. The user mentions they installed git codereview on a new machine; likely need to set up a Gerrit cookie. Consider adding documentation or detection for missing cookie.