golang/go

x/tools/gopls: hover over unkeyed field should show field info

Open

#70450 opened on Nov 19, 2024

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Go (133,883 stars) (19,008 forks)batch import
FeatureRequestToolsgoplshelp wanted

Description

When hovering over the name of a field in a composite literal, we show info about that field.

But when hovering over a value in an unkeyed literal, we show nothing. If anything, field information would be more useful in an unkeyed literal! I recently bumped into this while working in the middle of a large table driven test.

This should be easy to add.

Contributor guide

Tech stack
go
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Gogoplscomposite literals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the gopls hover logic for composite literals. The issue suggests adding hover info for unkeyed field values. The relevant code is likely in the gopls analysis package (hover.go). Currently keyed fields show field info; extend the same to unkeyed literals by extracting field information from the type. No linked PRs or specific file references yet, but the issue states it should be easy to add.